Skip to content

Conversation

metascroy
Copy link
Contributor

This adds more intx_opaque_tensor to _convert_model_for_aarch64.

Copy link

pytorch-bot bot commented Sep 12, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2996

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 422bc35 with merge base f9bc52d (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 12, 2025
@metascroy metascroy requested a review from lisjin September 12, 2025 23:09
@metascroy metascroy changed the title Add intx tensor conversion + tied embeddings to _convert_model_for_aarch64 Add intx_opaque_tensor and tied embeddings to _convert_model_for_aarch64 Sep 12, 2025
pytest -s test/quantization/quantize_/workflows/intx/test_intx_opaque_tensor.py
pytest -s test/prototype/test_embedding.py
pytest -s test/prototype/test_int8_lut_tensor.py
pytest -s test/prototype/test_conversion.py
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: test_tensor_conversion.py

@metascroy metascroy added the topic: not user facing Use this tag if you don't want this PR to show up in release notes label Sep 15, 2025
Copy link
Contributor

@lisjin lisjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@metascroy metascroy merged commit 4dffb40 into main Sep 15, 2025
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing Use this tag if you don't want this PR to show up in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants